Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n]: Change apostrophe #14489

Merged
merged 2 commits into from
Feb 27, 2025
Merged

[l10n]: Change apostrophe #14489

merged 2 commits into from
Feb 27, 2025

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Feb 23, 2025

Corrected the apostrophe.

@Valdnet Valdnet self-assigned this Feb 23, 2025
@Valdnet Valdnet requested a review from Antreesy February 23, 2025 17:52
@Antreesy Antreesy force-pushed the Valdnet-patch-1 branch 2 times, most recently from 4c173d4 to 8cd47d6 Compare February 24, 2025 11:06
@nickvergessen nickvergessen added this to the 🪺 Next Major (32) milestone Feb 24, 2025
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Feb 24, 2025
@nickvergessen
Copy link
Member

/backport to stable31

@nickvergessen
Copy link
Member

Scheduling backport to 31, but should only merge after the final, so translations can be updated in time.

@Antreesy
Copy link
Contributor

cc @nickvergessen I might have missed to adjust some other tests, or integrations failure are unrelated to this PR?

@nickvergessen
Copy link
Member

Yeah migrated all usages, so it broke when testing federation with another version.
Filtering both fixes it.

@nickvergessen
Copy link
Member

Counter direction has to be fixed in stable31, so let's wait with merging until tomorrow and then also merge the backport right away

@rakekniven
Copy link
Member

Please merge now after final of NC31 is out

Valdnet and others added 2 commits February 27, 2025 09:14
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

/backport to stable31

@nickvergessen nickvergessen merged commit 7f79bd4 into main Feb 27, 2025
76 of 78 checks passed
@nickvergessen nickvergessen deleted the Valdnet-patch-1 branch February 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants